|
FastMail Forum All posts relating to FastMail.FM should go here: suggestions, comments, requests for help, complaints, technical issues etc. |
|
Thread Tools |
28 Jul 2010, 12:30 AM | #1 |
The "e" in e-mail
Join Date: Jul 2004
Location: Melbourne, Australia
Posts: 2,696
Representative of:
Fastmail.fm |
Bugs fixed today
I'll let Rob do a more general blog post tomorrow - but here's what I've done today, unedited Number 1 was actually a killer that involved pulling a bunch of work that I'd done because it was blatantly wrong! Hate that. The end result was a lot better code - consolidating two different sets of sequence handling inside Cyrus, and writing a command line tool that uses it, which can be used for testing in future
1) sequence reading bug Could have caused a range of FETCH and STORE bugs (possibly related to messages re-appearing as UNSEEN or even no longer expunged). Basically if you had a sequence of the type 6:8,1:3 - where there were lower UIDs later in the sequence, it would fail to operate on those numbers. This was quite visible to me in offlineimap with messages reappearing! 2) XLIST missing I hadn't put XLIST in the server because the list format had changed. I didn't expect it to break anything, but it was responsible for the Mailstore issues. I forgot that the nginx frontends still advertise XLIST support BEFORE authentication. You're suppose to check for capabilities again afterwards, but hey. I've added it now. The LIST code had changed considerably, so I basically wrote a brand new patch. 3) NOOP on Mac Mail Yeah, this one too. I had to remove UIDs from being printed in NOOP responses as well as IDLE responses. I went back to the old Cyrus and confirmed they weren't being printed there! 4) Losing \Seen state on flag update STORE FLAGS (\Deleted \Seen) And the message ALREADY HAD a \Seen set, it would be lost. What a pain. I've fixed that, and made a couple of other minor improvements to how the flags get printed afterwards too Basically if you set a flag that didn't exist and didn't specify .SILENT, it failed to print the flag name due to the ordering of actions. I've fixed that now. Rolled out, and I'm going to sleep! I've done extensive command line testing of all these patches, as well as using Thunderbird and Evolution locally. |
28 Jul 2010, 07:26 AM | #2 |
Master of the @
Join Date: Jul 2002
Location: Hampshire, UK
Posts: 1,238
|
Bron
Good stuff - many thanks for your hard work. Nigel |
28 Jul 2010, 12:55 PM | #3 |
The "e" in e-mail
Join Date: Jul 2002
Location: VK4
Posts: 3,012
|
wow what a lot of work.....thanks for letting us know its nice to know you are still alive seriously we do appreciate it.
Please tell Rob it would be nice to get it posted on here as some of us never read the blog |
28 Jul 2010, 06:54 PM | #4 |
The "e" in e-mail
Join Date: Dec 2004
Location: a virtually impossible but finitely improbable position
Posts: 2,320
|
Thanks, man.
Fastmail continues to be the best thing out there. |
Thread Tools | |
|
|